Closed
Conversation
tkoeppe
requested changes
Nov 8, 2023
Contributor
tkoeppe
left a comment
tkoeppe
left a comment
There was a problem hiding this comment.
Please fix the commit message: "tmep" should be "temp".
source/templates.tex
Outdated
| Default arguments for function templates and for member functions of | ||
| class templates are considered definitions for the purpose of template | ||
| instantiation\iref{temp.decls} and must obey the one-definition rule\iref{basic.def.odr}. | ||
| instantiation\iref{temp.decls} and thus the one-definition rule\iref{basic.def.odr} applies. |
Contributor
There was a problem hiding this comment.
Please add a comma before "and".
Contributor
There was a problem hiding this comment.
@jensmaurer Would you have a moment for this ^^^?
Member
Author
Fixed. |
Contributor
|
Can we fold this into #6737? |
Member
Author
|
Already covered by #6737 . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partially addresses cplusplus/nbballot#578